-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailchimp contacts for not registered users #88
base: master
Are you sure you want to change the base?
Mailchimp contacts for not registered users #88
Conversation
@SergeyMell The change you have done as far as i am understanding here is If a guest user comes and adds products without logging in and signing up. Then you want to include it in |
@@ -6,16 +6,14 @@ class AbandonedCart < Spree::Marketing::List | |||
NAME_TEXT = 'Abandoned Cart' | |||
AVAILABLE_REPORTS = [:purchases_by].freeze | |||
|
|||
def user_ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeyMell You can't just replace user_ids
method. It will simply raise exception as mentioned here .
If you want to change this list type. You will have need to change the whole flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only place where user_ids
is used is method users
. As long as I've changed this method it won't break anything. The only thing I should change is 3 test cases - I'll do this ASAP.
No, it will not because I'm using |
@SergeyMell I will verify this thing by running you code. And get back to you. |
@SergeyMell Have you been able to change the test cases as mentioned above? |
Implemented creating mailchimp contacts for not registered users (Abandoned carts list)